Table of Contents |
---|
To develop IGB and the IGB API, the core IGB development team uses the Forking Fork-and Feature -Branch Workflows described Workflow described in https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow
The following sections describe how to use this workflow to modify IGB. This assumes you understand the basics of how to use git.
Fork the code on Bitbucket
To contribute a change to the IGB code base, create your own fork of the IGB team repository.
To create your own fork:
- Sign up for Bitbucket account
- Go to http://bitbucket.org/lorainelab/integrated-genome-browser (the team repository)
- Select Fork
Next, you'll see a form that let's you give your fork a name and description. Here's an example:
Fill in the fields and click Fork repository.
After a moment, an Overview page for your forked repository will appear.
Also see Atlassian documentation Forking a Repository.
Clone your fork
Clone a copy of your forked IGB repository onto your computer. You will make changes to your local clone, commit them to your local repository, and then ultimately push your changes to your fork hosted on Bitbucket.
To clone your fork:
Code Block | ||
---|---|---|
| ||
git clone <ADDRESS> |
where ADDRESS is the address of your fork on Bitbucket. To get the address of your fork, look at the top the top right of your fork's Overview page on Bitbucket.
To avoid having to enter your password each time you interact with your fork on BitBucket, set up ssh for git. See: Set up SSH for Git.
Add "upstream" - an alias to the team repository
Use git to add the team repository as a new remote repository to your local clone. By convention, the team repository (which you forked) should be named "upstream".
To add Quick Summary: Developers fork the team repository on Bitbucket. When working on a bug fix or new feature, they create a topic branch specific to that task. They push their branch to their fork for review and testing. When all is done, they submit a pull request from the topic branch on their fork to the main branch on the team repository. When working on a task recorded in the IGB JIRA system, they include the corresponding JIRA number (e.g., IGBF-1234) in the branch name and every commit to that branch.
Table of Contents |
---|
...
Step-by-Step Set-up Guide
Fork the code on Bitbucket - configure your fork
- Sign up for a free account on Bitbucket. Use an "edu" address if you have one to get more "build minutes" with Bitbucket pipelines.
- Set up ssh for git to avoid having to enter your password every time you interact with Bitbucket using git. See: Set up SSH for Git.
- Using your Bitbucket account, fork the team repository: https://bitbucket.org/lorainelab/integrated-genome-browser
- Configure your fork to link to team project management software JIRA.
- Log into Bitbucket
- Go to your fork home page
- Select "Settings > Links > Add new link"
- Choose Link type "Jira"
- Enter Link url https://jira.bioviz.org/
- Enter Link key IGBF
- Check that the links work - select "Commits"
- Look for commit messages containing the Link key "IGBF"
- Note that all link keys now link out to JIRA
Install Git
- Windows users: Git for Windows
Clone your fork and add the team repository as "upstream"
- Clone a copy of your forked IGB repository onto your computer using your favorite git client software.
- Add the team repository as a remote called "upstream" (the convention.)
For example:
Code Block | ||
---|---|---|
| ||
git remote add upstream <ADDRESS> |
where ADDRESS is the address of the team repository.
...
git@bitbucket.org:lorainelab/integrated-genome-browser.git |
Start work - make a branch
Before you start work on a new feature, bug fix, or other improvement, create a new branch for the changes you intend to make. This new branch is called a "topic branch" and should only address one specific, discrete feature or bug fix. This is critical! Doing this will allow you to issue focused, low risk pull requests that are easy to merge with other developers' work.To make a new topic branch
Important: If you are working on a task captured in the IGB JIRA project, include the JIRA issue number in the branch name. This enables the JIRA and Bitbucket sites to create links to each other.
For example:
Code Block | ||
---|---|---|
| ||
git checkout -b <BRANCH>IGBF-1234 |
where BRANCH IGBF-1234 is the name of the new branch. Branch names always should refer to issues in the JIRA issue-tracking system - for example: IGBF-203. Branches should always derive from the master branch, the main line of development for IGB. To ensure this happens, make sure you are "on" the master branch before creating a new branch.Note: Topic branches are sometimes also called "feature branches." However, this is may not be the best name because often branches deal with bug fixes or improvements to existing features. The IGB project prefers the term "topic branch" because it is more general
To test your set-up, trying compiling and running IGB.
To build and run IGB from the command line:
- Install Apache maven (these directions from the Baeldung site are helpful)
- Change into the project directory and type mvn install
- Start IGB by running one of the "run_igb" scripts in the top level of the project.
Note: Following the upgrade of IGB to Java 21, it may not be possible to run IGB from within an IDE. This is due to the requirement to expose internal Java modules. You should be able to build IGB from within the IDE, but to run it please use one of the "run_igb" scripts from your terminal.
Edit code, commit to your clone, push to your fork
Edit your code, test it locally, commit your changes edits to your local copy, and then push them to your fork hosted on Bitbucket. If working on a JIRA issue, always include the JIRA ticket name in the commit.
For example:
...
:
Code Block |
---|
git commit -m "CorrectingIGBF-1234 aFix typo - joecovfefe insteadnot of jeo" |
- Push to the remote repository, aliased to "origin"
Code Block |
---|
git push origin BRANCH |
Note that "origin" is aliased to your fork on Bitbucket, not the team repository.
collusion" |
Synchronize early & often with the main repository
If the main development branch changes, you must obtain those changes and test them with your branch.
First step is to To update your copies of the master branch. Note that this assumes you have already added the team repository as a remote repository named "upstream."To synchronize your clone and your fork, switch back to the master branchfork's copy of the main branch, check out your main branch on your clone and pull changes from the main branch from the team repository, aliased to "upstream." Then, push the changes to your fork.
For example:
Code Block |
---|
git checkout master |
pull the new commits from master to your local clone:
Code Block |
---|
main git pull upstream master |
and push the new commits to your fork:
Code Block |
---|
main git push origin master |
Recall that "origin" is aliased to your fork on bitbucket.
...
main |
If all goes well, your fork will then receive all the commits present on the main branch on the team repository. To check that it worked, just review the commit history on your fork and compare it to the team repository.
Rebase your branch
After updating your clone and fork with the latest changes to the master main branch, you'll need to test how those new commits interact with your topic branch. The IGB team recommends you You should use "rebase" commands to do this. This will move the "base" of your topic branch to the latest commit on the master main branch.
To rebase your branch on the latest mastermain, update switch back to the master branch (see above)main branch, update it with any new commits, check out your feature branch, and rebase.
For example, let's assume you have committed all your work to your topic branch - called IGBF-1234 in this example. Then run:
Code Block |
---|
git checkout <BRANCH> main git pull origin main # assumes your fork is up-to-date git checkout IGBF-1234 git rebase mastermain |
Push Next, push your newly rebased branch to "origin" (your fork) to update it:
Code Block |
---|
git push origin <BRANCH> |
...
IGBF-1234 |
Squash commits
If you have made multiple commits for a single Jira ticket it is usually best to squash the commits into a single commit before creating a pull request. See the Git cheat sheet for more information.
Make a pull request - PR
To request that your edits be incorporated into the team repository - aliased to "upstream" - , you need to issue make a pull request (PR).
To make a PR using the Bitbucket UI:
- Log in to your Bitbucket account.
- Go to your fork 's project Overview page
- Select Create Pull Request
...
- and select "Branches"
- Under "Pull request" select "Create" next to your branch
- A form will appear. Fill in the fields:
- Select your
- fork and your branch as the pull request source (left side).
- Select the
- team repository (lorainelab) and main branch as the pull request target (right side)
- Fill in the Title and Description fields
- Click Create pull request
Note that the team repository already has dozens of branches, most of them leftover from older workflows. DON'T push your branch as an all-new branch to the team repository. And DON'T merge your branch with master.
Other info
GenoViz Software Development Kit
IGB uses graphical user interface components in the GenoViz Software Development Kit. Normally, when you build IGB, you'll use a copy of the GenoViz SDK downloaded from our maven repository at http://eos.transvar.org/nexus/. However, if you clone and build your own copy, your version will automatically get added to your local maven repository.
Building javadocs
To build javadocs, run
- Click Create pull request
Things you need to know about PRs:
- If you make changes to your branch (the source of the PR), those changes will be reflected in the PR. You do not need to create a new PR if you add new commits or otherwise modify your branch.
- You should always rebase onto the latest main branch before submitting a PR.
- Please squash all your commits into one single commit, unless you have a very good reason not to. This ensures that we can easily apply your changes to other branches if required. It also makes code review easier.
- The project admins get email notifications whenever someone submits a PR. However, if you do not hear anything about your PR, get in touch.
Testing your code changes
NOTE:
When you build IGB, existing jar files in the repositories bundle directory are allowed to persist.
This may effect any code changes you may be trying to test.
To be sure that the IGB build you are running reflects the code you currently have, clear all jar files in the bundles directory before building.
In Development:
- In top level of git repository:
- $ rm *.jar bundles/
- Then build the project:
- in Netbeans: right click > clean and build
- in command line: mvn clean install
or
In IGB:
- Reset preferences to default by: Launching IGB > Preferences > Other Options > Reset Preferences to Default
- Delete the IGB folder in AppData located at C:\Users\<user>\AppData\Roaming\IGB (sometimes the AppData folder is "hidden", Go to the View tab in File Explorer and check the Hidden Items checkbox)
- Go to the IGB installation folder (defaults to C:\Program Files\IGB ) and run the uninstall.exe application there.
- Now when you reinstall IGB, it should act as if IGB has never been installed.
Learning git
The IGB team highly recommends working through the tutorials in Learning Git Branching - https://learngitbranching.js.org/?locale=en_US. Also, when you rebase for the first (or second or third) time, it's helpful to repeat the tutorial on rebasing. Don't worry. You will get the hang of it.